RFR(S): 8181592: [TESTBUG] Docker test utils and docker jdk basic test

George Triantafillou george.triantafillou at oracle.com
Mon Sep 25 18:21:39 UTC 2017


Hi Misha,

test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java:

197      * Convenicence method - by defaul retains stdout of child process

Should be:
* Convenience method - by default retains stdout of child process

215      * @param pb process to executed specified as ProcessBuilder

Should be:
* @param pb process to be executed specified as ProcessBuilder

-George

On 9/21/2017 8:58 PM, mikhailo wrote:
> Please review this initial drop of Docker test utils and a sanity 
> test. This change lays ground
> for further test development and test utils improvement in this area.
>
>     JBS: https://bugs.openjdk.java.net/browse/JDK-8181592
>     Webrev: http://cr.openjdk.java.net/~mseledtsov/8181592.00/
>     Testing:
>        - run this test on machine with Docker enabled - works
>        - run this test on Linux-x64 with no Docker engine or Docker 
> disabled - test skipped (as expected)
>        - run this test on automated system - in progress
>
>
> Thank you,
> Misha
>



More information about the hotspot-runtime-dev mailing list