RFR(S): 8201430: [TESTBUG] Remove script from runtime/6626217

[Doerr, Martin]

Looks good to me, now.

Best regards,
Martin


-----Original Message-----
From: Lindenmaier, Goetz 
Sent: Donnerstag, 12. April 2018 17:55
To: Doerr, Martin <martin.doerr at sap.com>; David Holmes <david.holmes at oracle.com>; hotspot-runtime-dev at openjdk.java.net
Subject: RE: RFR(S): 8201430: [TESTBUG] Remove script from runtime/6626217

Ahh, had to adapt TEST.groups.

Can I please get another go for this tiny addition?
http://cr.openjdk.java.net/~goetz/wr18/8201430-removeScript/02/

Then I'll push it to hs (or jdk if hs is closed).

Best regards,
  Goetz.


> -----Original Message-----
> From: Doerr, Martin
> Sent: Thursday, April 12, 2018 2:38 PM
> To: David Holmes <david.holmes at oracle.com>; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>; hotspot-runtime-dev at openjdk.java.net
> Subject: RE: RFR(S): 8201430: [TESTBUG] Remove script from
> runtime/6626217
> 
> Hi Götz,
> 
> I agree with David. Please fix the "!errorMsg.contains("")". Besides that, the
> change looks good to me as long as the jtreg commands work as expected
> (which I'm not so familiar with). At least I like your version more than using
> the script.
> 
> Best regards,
> Martin
> 
> 
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> bounces at openjdk.java.net] On Behalf Of David Holmes
> Sent: Mittwoch, 11. April 2018 23:40
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: Re: RFR(S): 8201430: [TESTBUG] Remove script from
> runtime/6626217
> 
> Hi Goetz,
> 
> This mostly seems reasonable ... though I'm never too sure when jtreg
> might decide to recompile something when processing @run.
> 
> In runtime/6626217/bug_21227.java:
> 
>   92             if (!errorMsg.contains("")) {
> 
> this doesn't look right - aren't you looking for "loader constraint"?
> 
> Thanks,
> David
> 
> On 11/04/2018 10:58 PM, Lindenmaier, Goetz wrote:
> > Hi,
> >
> > having looked into this anyways, I removed the script from
> > this test.
> >
> > Please review:
> > http://cr.openjdk.java.net/~goetz/wr18/8201430-removeScript/01
> >
> > Best regards,
> >    Goetz.
> >