[11] RFR(XS): 8207139: NMT is not enabled on Windows 2016/10

[Markus Gronlund]

Thanks David!

Cheers
Markus

-----Original Message-----
From: David Holmes 
Sent: den 1 augusti 2018 23:37
To: Markus Gronlund <markus.gronlund at oracle.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: [11] RFR(XS): 8207139: NMT is not enabled on Windows 2016/10

Hi Markus,

Thanks for taking this one!

On 2/08/2018 12:07 AM, Markus Gronlund wrote:
> Greetings,
> 
> Kindly asking for a review for the following change set:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8207139
> Webrev: http://cr.openjdk.java.net/~mgronlun/8207139/webrev00/
> Testing: hotspot_nmt

Looks good to me. Only minor concern is whether using a variable for the array size:

    char nmt_env_variable[buffer_size];

is relying on a compiler feature that may not be available in older VS versions people may still be using. But I guess that will get reported pretty quickly if it is an issue.

Thanks,
David

> Please see the bug for further details about this problem.
> 
> Thanks in advance
> Markus
>