RFR (S) 8164683: Solaris: JVM abuses thread preemption control
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Aug 9 22:46:37 UTC 2018
On 8/9/18 6:09 PM, Patricio Chilano wrote:
> Hi Coleen,
>
> The change looks good to me! I only see one extra mention to schedctl
> in objectMonitor.cpp not being removed ("Because of the lifecycle
> issues the schedctl and...").
Thank you Patricio! I've added punctuation and removed schedctl from
the comment.
// Because of the lifecycle issues, the _thread_state values
// observed by NotRunnable() might be garbage. NotRunnable must
// tolerate this and consider the observed _thread_state value
// as advisory.
Somewhat frightening comment though.
thanks,
Coleen
>
> Thanks,
>
> Patricio
>
>
> On 8/9/18 11:26 AM, coleen.phillimore at oracle.com wrote:
>> Summary: Complete removal of preemption control and command line
>> arguments (were deprecated in 11).
>>
>> Tested with hs-tier1-5 on solaris.
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8164683.01/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8164683
>>
>> Tested message manually (I really don't see the point of add testing
>> the message to a test, only to have to remove in 13).
>>
>> % java -XX:+VMThreadHintNoPreempt -version
>> Java HotSpot(TM) 64-Bit Server VM warning: Ignoring option
>> VMThreadHintNoPreempt; support was removed in 12.0
>> java version "12-internal" 2019-03-19
>> Java(TM) SE Runtime Environment 19.3 (fastdebug build
>> 12-internal+0-2018-08-08-1809283.coleen.12preempt)
>> Java HotSpot(TM) 64-Bit Server VM 19.3 (fastdebug build
>> 12-internal+0-2018-08-08-1809283.coleen.12preempt, mixed mode)
>>
>> Thanks,
>> Coleen
>>
>
More information about the hotspot-runtime-dev
mailing list