RFR(S): 8209164: [TESTBUG] Apply jtreg skipped status to cds tests

[Mikhailo Seledtsov]

Here is the updated webrev: 
http://cr.openjdk.java.net/~mseledtsov/8209164.02/
Hopefully addressing all the feedback.

Thank you,
Misha

On 8/9/18, 6:44 PM, Mikhailo Seledtsov wrote:
>
>
> On 8/9/18, 4:22 PM, Ioi Lam wrote:
>> Hi Misha,
>>
>> I think you should change checkCommonExecExceptions to a void 
>> function, since it now always throws or returns false.
>>
>> That way, you can catch places that try to read the return value, and 
>> fix these as appropriate. E.g., this in the Result class
>>
>>             hasMappingFailure = 
>> CDSTestUtils.checkCommonExecExceptions(output);
>>             hasAbnormalExit   = (!hasMappingFailure) && 
>> (output.getExitValue() != 0);
>>             hasNormalExit     = (!hasMappingFailure) && 
>> (output.getExitValue() == 0);
>>
>> I think the Result.hasMappingFailure field can now be removed.
> Sounds good; I think I can fix that as well with this change.
>>
>> Thanks
>>
>> - Ioi
>>
>>
>> On 8/9/18 1:50 PM, Mikhailo Seledtsov wrote:
>>> Please review this straight forward change. Now that JTReg harness 
>>> supports the "skipped status",
>>> this change updates CDS and AppCDS tests to use this mechanism where 
>>> applicable.
>>>
>>>     JBS: https://bugs.openjdk.java.net/browse/JDK-8209164
>>>     Webrev: 
>>> http://cr.openjdk.java.net/~mseledtsov/8209164.01/index.html
>>>     Testing:
>>>         1. Locally: exercised tests under runtime/SharedArchiveFile 
>>> and runtime/appcds on Linux-x64
>>>            No new failures
>>>     2. Run runtime/SharedArchiveFile and runtime/appcds via 
>>> distributed test system
>>>            Run tier1,tier2
>>>            In progress
>>>
>>> Thank you,
>>> Misha
>>