RFR 8206424: Use locking for cleaning ProtectionDomainTable

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Aug 21 21:11:46 UTC 2018


Patricio,

This looks really good.  I agree with Ioi's comment.  Maybe the test 
could go into test/hotspot/jtreg/runtime/Dictionary (there are similar 
tests there?)

Also the copyright should just have 2018 followed by a comma (even 
though grammatically incorrect).

thanks,
Coleen

On 8/21/18 2:47 PM, Patricio Chilano wrote:
> Hi all,
> Could you review this fix that moves the cleanup of dead entries in 
> the protection domain table from the VMThread to the ServiceThread.
> The goal is the same as JDK-8206423. The task of cleaning up dead 
> entries in the protection domain table was moved to the ServiceThread.
> The fix was tested with Mach5 on tiers 1, 2, 3 on all platforms. A new 
> test (test/hotspot/jtreg/runtime/appcds/CleanProtectionDomain.java) 
> was added to test the creation and removal of entries in the 
> Protection Domain table.
> Bug URL: https://bugs.openjdk.java.net/browse/JDK-820642 
> <https://bugs.openjdk.java.net/browse/JDK-8206423>4
> Webrev 
> URL: http://cr.openjdk.java.net/~pchilanomate/8206424.01/webrev/index.html
> Thanks,
> Patricio
>



More information about the hotspot-runtime-dev mailing list