RFR[XS] 8210246 NMTUtil::_memory_type_names should be in sync with MemoryType

Jiangli Zhou jiangli.zhou at oracle.com
Fri Aug 31 00:15:43 UTC 2018


Looks good. Could you please align the ending '\' for the following 
lines. No additional webrev needed for the formatting change.

  111   /* Memory type by sub systems. It occupies lower byte. */ \
  112   f(mtJavaHeap,      "Java Heap")   /* Java heap */ \
  113   f(mtClass,         "Class")       /* Java classes */ \
  114   f(mtThread,        "Thread")      /* thread objects */ \
  115   f(mtThreadStack,   "Thread Stack") \
  116   f(mtCode,          "Code")        /* generated code */ \


Thanks,
Jiangli

On 8/30/18 4:57 PM, Ioi Lam wrote:
> https://bugs.openjdk.java.net/browse/JDK-8210246
> http://cr.openjdk.java.net/~iklam/jdk12/8210246-memory_type_names.v01/
>
> This is a small clean up:
>
> MemoryType and _memory_type_names should be in sync, but they were
> coded independently in 2 files, and it's possible to change one while
> forgetting to change the other.
>
> The fix is, as always, some fancy macros.
>
> Thanks
> - Ioi



More information about the hotspot-runtime-dev mailing list