RFR(XS): 8210259: [testbug] IncompatibleOptions.java fails if VM configured without ZGC

[Per Liden]

On 08/31/2018 03:21 PM, Lindenmaier, Goetz wrote:
> Hi Per,
> 
> Thanks for the review!
> 
> Yes, the check could be there for the other gcs, too.
> But I guess I would have to roll this out to hundreds of tests
> to make it consistent.

Yep, that would affect a ton of tests, so let's be pragmatic and do this 
only where we currently have a need for it.

cheers,
Per

> 
> Best regards,
>    Goetz.
> 
>> -----Original Message-----
>> From: Per Liden <per.liden at oracle.com>
>> Sent: Freitag, 31. August 2018 14:33
>> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-
>> dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8210259: [testbug] IncompatibleOptions.java fails if VM
>> configured without ZGC
>>
>> On 08/31/2018 01:58 PM, Lindenmaier, Goetz wrote:
>>> Hi,
>>>
>>> could I please get reviews for this tiny fix?
>>> http://cr.openjdk.java.net/~goetz/wr18/8210259-
>> fixNoZGCError/webrev.01/
>>>
>>> The testcase enabling ZGC is protected by (Platform.isLinux() &&
>> Platform.isX64()).
>>> Thus, the test fails if the VM is compiled without ZGS on linuxx86_64.
>>> Fix: use GC.Z.isSupported()
>>
>> Looks good!
>>
>> (In theory we should have this test for all other GCs too, since they
>> can also be compiled out, and it would be nice if testing passed
>> anyway... but let's not go there now...)
>>
>> /Per