(trivial) RFR: 8196739: Disable obsolete/expired VM flag transitional warnings
David Holmes
david.holmes at oracle.com
Sat Feb 3 01:21:52 UTC 2018
Bug: https://bugs.openjdk.java.net/browse/JDK-8196739
webrev: http://cr.openjdk.java.net/~dholmes/8196739/webrev/
If, for example, a flag is listed as deprecated in 10 and obsolete in 11
and we simply switch the version to 11 without actually obsoleting the
flag (ie removing it) we get a VM warning in debug builds as a reminder
that this needs to be done eg:
Java HotSpot(TM) 64-Bit Server VM warning: Global variable for obsolete
special flag entry "FastTLABRefill" should be removed
This was considered a good thing to do to ensure we didn't forget to do
the obsoleting or expiration. In practice it is causing problems as we
prepare to go to version 11 because, unfortunately, there are many tests
that can not tolerate unexpected warnings in the VM output and will
fail. While many of these have been fixed (for tier1 and tier2 test
groupings) there are still a number to fix for tier3 and above, and it
is simply taking too long and delaying the version update.
So as a temporary measure we will simply disable these transitional
warnings so that the tests pass. Bugs will also be filed against those
tests so this is not an issue in the future. A subtask has been created
to reenable the warnings later.
Note that if you actually use an obsolete flag you will of course get a
warning about that.
Thanks,
David
--- old/src/hotspot/share/runtime/arguments.cpp 2018-02-02
20:19:36.701599520 -0500
+++ new/src/hotspot/share/runtime/arguments.cpp 2018-02-02
20:19:35.077506693 -0500
@@ -729,7 +729,8 @@
// if flag has become obsolete it should not have a "globals"
flag defined anymore.
if (!version_less_than(JDK_Version::current(), flag.obsolete_in)) {
if (Flag::find_flag(flag.name) != NULL) {
- warning("Global variable for obsolete special flag entry
\"%s\" should be removed", flag.name);
+ // Temporarily disable the warning: 8196739
+ // warning("Global variable for obsolete special flag entry
\"%s\" should be removed", flag.name);
}
}
}
@@ -738,7 +739,8 @@
// if flag has become expired it should not have a "globals"
flag defined anymore.
if (!version_less_than(JDK_Version::current(), flag.expired_in)) {
if (Flag::find_flag(flag.name) != NULL) {
- warning("Global variable for expired flag entry \"%s\" should
be removed", flag.name);
+ // Temporarily disable the warning: 8196739
+ // warning("Global variable for expired flag entry \"%s\"
should be removed", flag.name);
}
}
}
More information about the hotspot-runtime-dev
mailing list