RFR(XS) 8194934: NMT: Remove MemTracker::get_virtual_memory_xxx_tracker(), create Tracker in place

Zhengyu Gu zgu at redhat.com
Mon Feb 5 18:27:03 UTC 2018


Hi Coleen,

Please find attached patch.

Thanks,

-Zhengyu


On 02/05/2018 01:06 PM, coleen.phillimore at oracle.com wrote:
> 
> Yes, this looks good, and trivial so I think we don't need another code 
> review.   I will sponsor it for you.
> Thanks,
> Coleen
> 
> 
> On 2/2/18 4:35 PM, Zhengyu Gu wrote:
>> MemTracker is a stack object, it locks ThreadCrtical in its 
>> constructor, and unlock it in destructor.
>>
>> Using MemTracker::get_virtual_memory_XXX_tracker() to acquire a 
>> tracker, causes an additional lock/unlock of ThreadCritical.
>>
>> This patch creates MemTracker in place to avoid the extra lock/unlock.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8194934
>> Webrev: http://cr.openjdk.java.net/~zgu/8194934/webrev.00/
>>
>> Test:
>>
>>   hotspot_tier1_runtime on Linux 64 (fastdebug and release)
>>
>>   Verified minimal VM build.
>>
>>
>> Thanks,
>>
>> -Zhengyu
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8194934.patch
Type: text/x-patch
Size: 5482 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20180205/f459248f/8194934-0001.patch>


More information about the hotspot-runtime-dev mailing list