RFR(XS): 8193308: Disallow installing user signal handlers for SIGBUS on OSX

David Holmes david.holmes at oracle.com
Wed Feb 7 10:49:24 UTC 2018


On 7/02/2018 8:22 PM, Robin Westberg wrote:
> Hi David,
> 
> Thanks for the review!
> 
>> On 7 Feb 2018, at 01:57, David Holmes <david.holmes at oracle.com 
>> <mailto:david.holmes at oracle.com>> wrote:
>>
>> Looks good Robin! Thanks for getting to the bottom of this one!
>>
>> Please update copyright years before pushing commiting.
> 
> Updated.
> 
>> Do you need a sponsor?
> 
> Ah, yes I do, if you have time it would be appreciated! Here’s an 
> updated webrev with a proper mercurial changeset in case that makes it 
> more convenient: http://cr.openjdk.java.net/~rwestberg/8193308/webrev.01/

It does indeed - thanks.

David

> Best regards,
> Robin
> 
>>
>> Thanks,
>> David
>>
>> On 7/02/2018 1:19 AM, Robin Westberg wrote:
>>> Hi all,
>>> Please review the following change to disallow installing user signal 
>>> handlers for SIGBUS on OSX. On OSX, SIGBUS is used internally by the 
>>> VM (where most other platforms only use SIGSEGV), and installing a 
>>> user handler can lead to a deadlock.
>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8193308 
>>> <https://bugs.openjdk.java.net/browse/JDK-8193308>
>>> Webrev: http://cr.openjdk.java.net/~rwestberg/8193308/webrev.00/ 
>>> <http://cr.openjdk.java.net/~rwestberg/8193308/webrev.00/>
>>> Testing: hs-tier1, hs-tier2
>>> Best regards,
>>> Robin
> 


More information about the hotspot-runtime-dev mailing list