RFR: 8197408: Bad pointer comparison and small cleanup in os_linux.cpp
David Holmes
david.holmes at oracle.com
Thu Feb 8 11:43:13 UTC 2018
Hi Robbin,
On 8/02/2018 7:03 PM, Robbin Ehn wrote:
> Hi all,
>
> There is a bad pointer comparison in os_linux.cpp while looking at that
You seem to be missing the fact that
OSContainer::cpu_cpuset_memory_nodes() can return a pointer or an error
code.
> I saw some if statement were missing bracket, a lot of extra scopes and
> complexity in the scoping.
You'd better check all this with Bob Vandette as its his container
support code.
Cheers,
David
> Webrev:
> http://cr.openjdk.java.net/~rehn/8197408/webrev/
> Bug:
> http://cr.openjdk.java.net/~rehn/8197408/webrev/
>
> Thanks, Robbin
More information about the hotspot-runtime-dev
mailing list