Take 2: RFR: 8197429: Increased stack guard causes segfaults on x86-32

Leonid Mesnik leonid.mesnik at oracle.com
Tue Feb 13 23:44:03 UTC 2018


Andrew 

Thank you for fixing tests. I think that it would be also better to rewrite test in java using process utilities test/lib/jdk/test/lib/process/ProcessTools.java.
It is possible to push shell test but the general direction for OpenJDK tests is to use java and testlibrary.
Now it is more easier to develop and debug tests with new processes using testlibrary. Also the could be execute faster.
But if you have any reasons to keep test in shell that I am fine. 

Leonid


> On Feb 13, 2018, at 6:51 AM, Andrew Haley <aph at redhat.com> wrote:
> 
> Webrev amended.
> 
> http://cr.openjdk.java.net/~aph/8197429-2/
> 
> Copyrights fixed.
> 
> Test case changed to be built with the rest of the native code.
> 
> We now only bang down the stack to its maximum size if we're going to
> run Java code on the primordial stack.  This only happens with the
> JNI invocation interface.
> 
> The new logic is:
> 
>  if we're on the primordial stack
>    bang down the stack to its maximum size
> 
>  try to map the codebuf just below the primordial stack
> 
>  if that didn't work
>    try to map again, but 1 megabyte lower
> 
> OK?
> 
> -- 
> Andrew Haley
> Java Platform Lead Engineer
> Red Hat UK Ltd. <https://www.redhat.com>
> EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671



More information about the hotspot-runtime-dev mailing list