Take 2: RFR: 8197429: Increased stack guard causes segfaults on x86-32

David Holmes david.holmes at oracle.com
Fri Feb 16 04:25:36 UTC 2018


On 16/02/2018 12:01 AM, Andrew Haley wrote:
> On 15/02/18 02:40, David Holmes wrote:
>> My main concern was to ensure that this did not somehow cause
>> DisablePrimordialThreadGuardPages to break. IIUC without the suggested
>> adjustment this change would slightly reduce the amount of stack
>> available for use - in which case I'd prefer to see the adjustment made
>> in either form you deem best.
> 
> OK.
> 
> http://cr.openjdk.java.net/~aph/8197429-3/
> 
> Here it is, with adjustment and a test for
> DisablePrimordialThreadGuardPages.

Thanks Andrew. Just one nit with the test:

   48 # Run the test for a java and native overflow
   49 ${TESTNATIVEPATH}/stack-gap
   50 ${TESTNATIVEPATH}/stack-gap -XX:+DisablePrimordialThreadGuardPages
   51 exit $?

Need to check we get zero exit code from first run before doing second.

David


More information about the hotspot-runtime-dev mailing list