RFR (XS): 8198560: Remove implicit casts from oop to JavaThread* and jlong*

Erik Osterlund erik.osterlund at oracle.com
Thu Feb 22 17:10:10 UTC 2018


Hi Thomas,

Thanks for the review.

/Erik

> On 22 Feb 2018, at 17:46, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
>> On Thu, 2018-02-22 at 17:44 +0100, Erik Österlund wrote:
>> Hi,
>> 
>> In the current state, oop may be implicitly casted to JavaThread*
>> and 
>> jlong*. There does not appear to be code relying on these casts, and 
>> therefore they should be removed. In the unlikely case this
>> operation 
>> would make sense, then you may use cast_from_oop<JavaThread*>(obj)
>> instead.
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8198560/webrev.00/
>> 
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8198560
>> 
> 
>  looks good.
> 
> Thomas



More information about the hotspot-runtime-dev mailing list