RFR(S): 8204591: Expire/remove the UseAppCDS option in JDK 12

Calvin Cheung calvin.cheung at oracle.com
Tue Jul 17 17:48:41 UTC 2018


Hi Misha, Jiangli,

Thanks for your quick review.

I already checked the entire repo and the UseAppCDS flag is no longer 
being used.
I also ran all CDS/AppCDS tests both locally and using mach5.

thanks,
Calvin

On 7/17/18, 10:26 AM, mikhailo wrote:
> +1, change looks good.
>
>
> I agree with Jiangli, please grep all HotSpot and JDK tests for 
> 'UseAppCDS', as well as task definitions (closed/task-definitions/), 
> just to be sure.
>
> Also, check the make files (CDS mode execution).
>
> And make sure to run all CDS and AppCDS tests.
>
>
> Thank you,
>
> Misha
>
>
> On 07/17/2018 09:26 AM, Jiangli Zhou wrote:
>> Hi Calvin,
>>
>> Looks good! You probably have already done it, please double check 
>> all jtreg tests to make sure there is no additional reference to 
>> UseAppCDS flag left.
>>
>> Thanks,
>>
>> Jiangli
>>
>>
>> On 7/17/18 9:18 AM, Calvin Cheung wrote:
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8204591
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8204591/webrev.00/
>>>
>>> The UseAppCDS option has been obsoleted in JDK 11, it will be 
>>> removed in JDK 12.
>>>
>>> With this change, if the UseAppCDS option is specified, vm will not 
>>> start.
>>>
>>> bash-4.2$ $MYJDK/bin/java -XX:+UseAppCDS -version
>>> Unrecognized VM option 'UseAppCDS'
>>> Error: Could not create the Java Virtual Machine.
>>> Error: A fatal exception has occurred. Program will exit.
>>>
>>> Ran hs-tier{1,2,3} tests successfully.
>>>
>>> thanks,
>>> Calvin
>>
>


More information about the hotspot-runtime-dev mailing list