RFR (S): C1 still does eden allocations when TLAB is enabled

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Fri Jul 20 18:46:46 UTC 2018


Vladimir,

It was my fault as well sorry.
Initially, this review was posted on runtime and hotspot.
I also asked to add the serviceability-dev.
Probably, the hotspot-dev has to be enough in this case.

Thanks,
Serguei


On 7/20/18 10:57, Vladimir Kozlov wrote:
> Please, don't do review in 2 mailing threads.
>
> Thanks,
> Vladimir
>
> On 7/20/18 8:30 AM, JC Beyler wrote:
>> Awesome thanks Thomas!
>>
>> Here is the webrev with the extra information then:
>> http://cr.openjdk.java.net/~jcbeyler/8207252/webrev.03/
>>
>> Thanks again for all the reviews everyone!
>> Jc
>>
>> On Fri, Jul 20, 2018 at 3:23 AM Thomas Schatzl 
>> <thomas.schatzl at oracle.com>
>> wrote:
>>
>>> Hi,
>>>
>>> On Mon, 2018-07-16 at 14:58 -0700, JC Beyler wrote:
>>>> Hi all,
>>>>
>>>> Here is a webrev that does all the architectures in the same way:
>>>> http://cr.openjdk.java.net/~jcbeyler/8207252/webrev.02/
>>>>
>>>> Could anyone review the other architectures and test?
>>>>    - arm, sparc & aarch64 are also modified now to follow the same "if
>>>> no
>>>> tlab, then consider eden space allocation" logic.
>>>>
>>>> Thanks for your help!
>>>> Jc
>>>>
>>>
>>>    looks good.
>>>
>>> I ran the change through hs-tier1-3 with no issues. It only tests on
>>> sparc and x64 though.
>>>
>>> I do not expect issues on the other platforms though :)
>>>
>>> Thanks,
>>>    Thomas
>>>
>>>
>>



More information about the hotspot-runtime-dev mailing list