RFR: 8205199: more Linux clang compile failures
Kim Barrett
kim.barrett at oracle.com
Tue Jun 19 02:15:56 UTC 2018
> On Jun 18, 2018, at 9:35 PM, Martin Buchholz <martinrb at google.com> wrote:
>
> Hej Gerard, here's a code review for you:
>
> 8205199: more Linux clang compile failures
> http://cr.openjdk.java.net/~martin/webrevs/jdk/more-linux-clang-failures/
> https://bugs.openjdk.java.net/browse/JDK-8205199
-----
717 static bool store_context(const void* context) {
718 if (memcpy(&g_stored_assertion_context, context, sizeof(ucontext_t)) == NULL) {
I don’t know what this code is supposed to be doing, but memcpy isn’t going to return
NULL here, any more than it would return false (as in the pre-change code).
——
The change to os_linux_x86.cpp looks good.
More information about the hotspot-runtime-dev
mailing list