RFR(xs): 8199431: Split up class Metaspace into a static and a non-static part

Thomas Stüfe thomas.stuefe at gmail.com
Wed Mar 14 18:55:54 UTC 2018


On Wed, Mar 14, 2018 at 6:01 PM, Andrew Dinn <adinn at redhat.com> wrote:

> On 14/03/18 16:24, Thomas Stüfe wrote:
> > Thats ok. ClassLoaderMetaspace - like the instance part of Metaspace
> > before - needs access to SpaceManager private functions to access the
> > expand_lock and some other stuff.
> >
> > In the first version of my webrev I added ClassLoaderMetaspace  as
> > friend but forgot to remove friend Metaspace, I think this is what
> > Coleen meant.
> Ah, yes -- I  also ended up looking at the wrong change set when I
> misread Coleen's comment.
>

Sorry for the confusion about the wrong webrev, and thanks for the review!
..Thomas

>
> As she says it would be better without the need for friending but that's
> no reason to delay this fix going in. All is good.
>
> regards,
>
>
> Andrew Dinn
> -----------
> Senior Principal Software Engineer
> Red Hat UK Ltd
> Registered in England and Wales under Company Registration No. 03798903
> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>


More information about the hotspot-runtime-dev mailing list