RFR(xs): 8229967: Enable thread local handshakes on zero

Aleksey Shipilev shade at redhat.com
Wed Aug 21 13:54:38 UTC 2019


On 8/21/19 10:19 AM, Robbin Ehn wrote:
> Hi all, please consider.
> 
> Zero can have handshakes enabled.
> This prepares the vm for removing global safepoints.
> 
> Built x64 and sanity tested. (should be platform independent)
> x86 do not build for me due to workaround_expand_exec_shield_cs_limit.
> 
> Thanks, Robbin
> 
> diff -r 7c20dcb59a68 src/hotspot/cpu/zero/globalDefinitions_zero.hpp
> --- a/src/hotspot/cpu/zero/globalDefinitions_zero.hpp    Mon Aug 19 13:43:51 2019 +0200
> +++ b/src/hotspot/cpu/zero/globalDefinitions_zero.hpp    Wed Aug 21 10:02:44 2019 +0200
> @@ -32,2 +32,4 @@
> 
> +#define THREAD_LOCAL_POLL
> +
>  #include <ffi.h>
> diff -r 7c20dcb59a68 src/hotspot/cpu/zero/globals_zero.hpp
> --- a/src/hotspot/cpu/zero/globals_zero.hpp    Mon Aug 19 13:43:51 2019 +0200
> +++ b/src/hotspot/cpu/zero/globals_zero.hpp    Wed Aug 21 10:02:44 2019 +0200
> @@ -78,3 +78,3 @@
> 
> -define_pd_global(bool, ThreadLocalHandshakes, false);
> +define_pd_global(bool, ThreadLocalHandshakes, true);

FWIW, linux-x86_64-zero-fastdebug bootcycles for me. Looks good!

-- 
Thanks,
-Aleksey



More information about the hotspot-runtime-dev mailing list