RFR(XS) 8230011 Consolidate duplicated classpath parsing code in classLoader.cpp

[Ioi Lam]

Hi Fred,

Thanks for the review. I will make the change as you suggested.

- Ioi

On 8/22/19 8:59 AM, Frederic Parain wrote:
> Ioi,
>
> ClasspathStream makes this code easier to read, but for the sake of
> readability, could the test at line 190 be more explicit:
>
> 190     while (_class_path[_end] && _class_path[_end] != os::path_separator()[0]) {
>
> It could be written like this:
>
> 190 while (_class_path[_end] != ‘\0' && _class_path[_end] != os::path_separator()[0]) {
>
> in order to avoid the implied boolean.
>
> Thank you,
>
> Fred
>
>
>> On Aug 22, 2019, at 00:23, Ioi Lam <ioi.lam at oracle.com> wrote:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8230011
>> http://cr.openjdk.java.net/~iklam/jdk14/8230011-consolidate-classpath-parsing.v01/
>>
>> Summary: moved the duplicated code into a single place: ClasspathStream
>>
>> Thanks
>> - Ioi