RFR: 8219229: Make ConstantPool::tag_at and release_tag_at_put inlineable

David Holmes david.holmes at oracle.com
Tue Feb 19 05:52:12 UTC 2019


Hi Claes,

On 18/02/2019 11:48 pm, Claes Redestad wrote:
> Hi,
> 
> JDK-8191102 moved tag_at and release_tag_at_put from constantPool.hpp to
> constantPool.cpp. These now outlined methods show up in startup
> profiles, especially when the bytecode verifier is enabled.
> 
> Moving these trivial methods (and some .hpp-defined methods they rely
> on) to constantPool.inline.hpp helps inlining and measurably improves
> timings in various startup benchmarks, while remaining footprint
> neutral. The patch also weeds out a few places where we were relying on
> an implicit include of constantPool.hpp.
> 
> Webrev: http://cr.openjdk.java.net/~redestad/8219229/open.00/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8219229

Can you explain why you moved an inline definition out of 
src/hotspot/share/oops/array.inline.hpp into the plain array.hpp file? 
That seems the reverse of what we're supposed to be doing. It also looks 
very odd to leave release_at_put as the sole method defined in the 
.inline.hpp file.

Thanks,
David
------

> Test: tier1+2
> 
> Thanks!
> 
> /Claes


More information about the hotspot-runtime-dev mailing list