RFR (XS): 8217765: Internal Error (javaCalls.cpp:61) guarantee(thread->can_call_java()) failed

Claes Redestad claes.redestad at oracle.com
Wed Feb 20 11:06:52 UTC 2019


Hi,

On 2019-02-20 01:53, David Holmes wrote:
> webrev: http://cr.openjdk.java.net/~dholmes/8217765/webrev.13/

+          if (log_is_enabled(Trace, class, nestmates)) {
+            ResourceMark rm(THREAD);
+            log_trace(class, nestmates)("- validation required 
resolution in an unsuitable thread");
+          }

The ResourceMark seems superfluous, so I think this should be
simplified to just the unguarded log_trace statement.

Otherwise looks good.

/Claes


More information about the hotspot-runtime-dev mailing list