RFR (trivial): 8219893: Compile warning: "Unconfigured platform" in jfrBigEndian.hpp on MIPS

[Jie Fu]

On 2019/2/28 下午12:18, David Holmes wrote:
> Hi Jie,
>
> Until there is a JEP for including the MIPS port in OpenJDK these 
> changes to support MIPS cannot be accepted.
>
> There is a concession made for ZERO which allows unsupported CPU 
> platforms to be referenced to allow ZERO to build on them. But in 
> general only code for supported ports should be added.
>
> These little changes should be applied as part of the integration of 
> the MIPS port, and handled under the implementation bug filed for that 
> port.
Okay.

Thanks David.

>
> Thanks,
> David
>
> On 28/02/2019 1:47 pm, Jie Fu wrote:
>> Hi all,
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219893
>>
>> A compile warning occurs while compile HotSpot VM on MIPS.
>> ---------------------------------------------
>> /home/loongson/fujie/jdk/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp:108:4: 
>> warning: #warning "Unconfigured platform" [-Wcpp]
>>     #warning "Unconfigured platform"
>>      ^
>> ---------------------------------------------
>>
>>
>> This can be fixed by
>> ---------------------------------------------
>> diff -r 8e069f7b4fab src/hotspot/share/jfr/utilities/jfrBigEndian.hpp
>> --- a/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp  Wed Feb 27 
>> 12:19:29 2019 -0800
>> +++ b/src/hotspot/share/jfr/utilities/jfrBigEndian.hpp  Thu Feb 28 
>> 11:05:38 2019 +0800
>> @@ -102,7 +102,7 @@
>>   inline bool JfrBigEndian::platform_supports_unaligned_reads(void) {
>>   #if defined(IA32) || defined(AMD64) || defined(PPC) || defined(S390)
>>     return true;
>> -#elif defined(SPARC) || defined(ARM) || defined(AARCH64)
>> +#elif defined(SPARC) || defined(ARM) || defined(AARCH64) || 
>> defined(MIPS)
>>     return false;
>>   #else
>>     #warning "Unconfigured platform"
>> ---------------------------------------------
>>
>>
>> The change has been tested on Linux/x64 and Loongson's 
>> Linux/mips64-port.
>>
>> Could you please review it?
>> Thanks a lot.
>>
>> Best regards,
>> Jie
>>
>>