RFR(XS): 8219714: [testbug] com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java must pass classpath to subprocess

[David Holmes]

Hi Goetz,

On 28/02/2019 6:16 pm, Lindenmaier, Goetz wrote:
> Hi,
> 
> as our testing runs a huge amount of tests in one batch,
> it should unveil most of these problems (for all tests after
> the first time Asserts was compiled to the central directory).
> But I'm not aware of any others.

All the rest of com/sun/jdi passed.

> Can I push the fix?

Yes - thanks.

David
-----

> Best regards,
>    Goetz.
> 
> 
>> -----Original Message-----
>> From: David Holmes <david.holmes at oracle.com>
>> Sent: Donnerstag, 28. Februar 2019 07:28
>> To: daniel.daugherty at oracle.com; Lindenmaier, Goetz
>> <goetz.lindenmaier at sap.com>; hotspot-runtime-dev at openjdk.java.net
>> Subject: Re: RFR(XS): 8219714: [testbug]
>> com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java must pass
>> classpath to subprocess
>>
>> <trimming>
>>
>> On 28/02/2019 3:20 am, Daniel D. Daugherty wrote:
>>> Thanks for chasing this one to ground.
>>>
>>> Is there some way we can determine if other tests have this same problem?
>>
>> Brute force: run a test that builds the test lib explicitly, then run
>> all other tests and see which ones fail. I'm doing that for com/sun/jdi.
>>
>> Only tests that exec other VMs which run code that uses the test library
>> can be affected.
>>
>> David
>>
>>> Dan
>>>
>>>
>>>>
>>>> Thanks,
>>>> David
>>>>
>>>>> Thanks,
>>>>> David
>>>>>
>>>>>> Exception in thread "main" java.lang.NoClassDefFoundError:
>>>>>> jdk/test/lib/Asserts
>>>>>> at Target.main(TestNestmateAttr.java:164)
>>>>>> Caused by: java.lang.ClassNotFoundException: jdk.test.lib.Asserts
>>>>>> at
>>>>>>
>> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.ja
>> va:583)
>>>>>>
>>>>>> at
>>>>>>
>> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoa
>> ders.java:178)
>>>>>>
>>>>>> at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521)
>>>>>>
>>>>>> Best regards,
>>>>>>     Goetz.
>>>>>>
>>>>
>>>