RFR(T) : 8219565: [deadcode] remove share/utilities/intHisto.*
Igor Ignatyev
igor.ignatyev at oracle.com
Thu Feb 28 17:10:25 UTC 2019
Hi David,
thanks for the review and the pointer to 8141049. was g1RemSet.cpp the last user of IntHisto?
Thanks,
-- Igor
> On Feb 27, 2019, at 10:20 PM, David Holmes <david.holmes at oracle.com> wrote:
>
> Hi Igor,
>
> On 28/02/2019 8:21 am, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev/8219565/webrev.00/
>>> 143 lines changed: 0 ins; 143 del; 0 mod;
>> Hi all,
>> could you please review this trivial clean up? recent code coverage analysis showed that "IntHistogram class doesn't seem to be used anywhere in hotspot, and can/should be removed." the patch is just 'hg rm src/hotspot/share/utilities/intHisto.*' + removing unneeded include in g1RemSet.cpp.
>
> FYI the usage in g1RemSet.cpp was removed by:
>
> 8141049: Remove CARD_REPEAT_HISTO from the G1 code
>
> but for some reason neither the include nor the IntHisto code were removed themselves.
>
> Removal looks good.
>
> Thanks,
> David
> -----
>
>> webrev: http://cr.openjdk.java.net/~iignatyev/8219565/webrev.00/
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8219565
>> testing: tier[1-2]
>> Thanks,
>> -- Igor
More information about the hotspot-runtime-dev
mailing list