[13] RFR(XS): 8227011: Starting a JFR recording in response to JVMTI VMInit and / or Java agent premain corrupts memory

[Markus Gronlund]

Thank you Erik for the review.

Can I please ask for a second reviewer?

Thanks
Markus


-----Original Message-----
From: Erik Gahlin 
Sent: den 1 juli 2019 14:31
To: Markus Gronlund <markus.gronlund at oracle.com>; hotspot-jfr-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
Subject: Re: [13] RFR(XS): 8227011: Starting a JFR recording in response to JVMTI VMInit and / or Java agent premain corrupts memory

Looks good.

Erik

> Greetings,
>
> Please review the following change set:
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8227011
> Webrev: http://cr.openjdk.java.net/~mgronlun/8227011/webrev01/
> Test: Testing: test/jdk/:jdk_jfr
>
> Summary:
> See bug.
>
> Comment:
> No test was added under this bug due to the relative complexities involved for reliable tests using instrumentation APIs.
> There should indeed be follow-up work to better test the interaction of the instrumentation APIs and JFR, some of it is tracked under https://bugs.openjdk.java.net/browse/JDK-8226779 .
>
> Thanks
> Markus