[13] RFR(L): 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds

Robin Westberg robin.westberg at oracle.com
Tue Jul 2 15:20:20 UTC 2019


Hi Markus,

Looks good to me!

Very minor nits:

src/hotspot/share/jfr/leakprofiler/sampling/objectSampler.cpp 131
s/succesful/successful/

src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp 441 
S/Exlusive/Exclusive/

Best regards,
Robin

> On 2 Jul 2019, at 15:08, Markus Gronlund <markus.gronlund at oracle.com> wrote:
> 
> Thank you Erik for the review.
> 
> Can I please ask for a second reviewer?
> 
> Thanks
> Markus
> 
> -----Original Message-----
> From: Erik Gahlin 
> Sent: den 1 juli 2019 16:49
> To: Markus Gronlund <markus.gronlund at oracle.com>
> Cc: hotspot-jfr-dev at openjdk.java.net; hotspot-runtime-dev at openjdk.java.net
> Subject: Re: [13] RFR(L): 8214542: JFR: Old Object Sample event slow on a deep heap in debug builds
> 
> Looks good.
> 
> Erik
> 
>> On 28 Jun 2019, at 17:56, Markus Gronlund <markus.gronlund at oracle.com> wrote:
>> 
>> Greetings, 
>> 
>> Kindly asking for reviews for the following changeset:
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214542 
>> Webrev: http://cr.openjdk.java.net/~mgronlun/8214542/webrev01/ 
>> Testing: test/jdk/:jdk_jfr
>> 
>> Summary:
>> Removal of heavy current_frontier assertion.
>> Trimmed down storage requirements by only storing necessary contextual edges.
>> Normalized representation of edges for better reuse.
>> Better preservation of already persisted tree structure by less intrusive reuse logic.
>> Caching.
>> 
>> Thank you in advance
>> Markus
> 



More information about the hotspot-runtime-dev mailing list