RFR: 8225035: Thread stack size issue caused by large TLS size

[Jiangli Zhou]

Hi Roger,

Thanks for the information!

Best regards,
Jiangli

On Mon, Jul 8, 2019 at 12:59 PM Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Hi,
>
>
> On 7/8/19 12:05 PM, Jiangli Zhou wrote:
>
> Hi Roger,
>
> On Mon, Jul 8, 2019 at 7:56 AM Roger Riggs <Roger.Riggs at oracle.com> wrote:
>
> Hi,
>
> src/hotspot/os/linux/os_linux.cpp:
>
> 849: typo in comment: "allocats" ->  "allocates"
>
> Fixed in place. Thanks!
>
>
>
> Will there be a release note describing the behavior and possibly the
> relation to the
> system property "jdk.lang.processReaperUseDefaultStackSize" added by
> 8086278  [1].
>
> A release note sounds like a good idea. The
> "jdk.lang.processReaperUseDefaultStackSize" system property seems no
> longer necessary with this more-general workaround, but that can be
> made as separate decision. Thoughts?
>
> yes, there's a separate issue filed to mitigate unexpected stack needs of the Process Reaper.
> JDK-8217475
>
> That might still be useful to mitigate unexpected memory use during initialization.
>
> If so, add a label release-note=yes to the issue and create a subtask
> with for the "Release Note:.....".
>
> Will do. The TLS issue and the new AdjustStackSizeForTLS option are
> Linux only, any additional process regarding the release note?
>
>
> There is a proposal for a code-tools project to formalize the generation of release notes
> though I haven't seen a response.
>
> https://mail.openjdk.java.net/pipermail/code-tools-dev/2019-April/000527.html
>
> There are some conventions for labeling release notes and process but I don't have them all in one place.
>
> The subtask should have a label = "release-note";
> There are labels starting with "RN-" that indicate what kind of change it is.
> RN-NewFeature might be appropriate.
> The first line should be written to be brief and specific about the change in behavior since
> it may be used in a list of release notes.
> Take a look at another release note for example: https://bugs.openjdk.java.net/browse/JDK-8223588
>
> Regards, Roger
>
>
>
>
> Best regards,
> Jiangli
>
> Thanks, Roger
>
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8086278
>
> On 7/8/19 10:27 AM, Jiangli Zhou wrote:
>
> Hi Florian,
>
> Here is the full webrev:
> http://cr.openjdk.java.net/~jiangli/8225035/webrev.05/, including the
> additional comments above get_static_tls_area_size.
>
> Best regards,
> Jiangli
>
> On Mon, Jul 8, 2019 at 2:27 AM Florian Weimer <fweimer at redhat.com> wrote:
>
> * Jiangli Zhou:
>
> As you, Florian, Thomas all made great contributions to this
> workaround, I should list all of you as both contributors and
> reviewers in the changeset. If there is any objection, please let me
> know.
>
> Can you share a link with the final patch?  I would like to have another
> look.
>
> Thanks,
> Florian
>
>