RFR[13, xs]: 8227275: Within native OOM error handling, assertions may hang the process

[coleen.phillimore at oracle.com]

http://cr.openjdk.java.net/~stuefe/webrevs/8227275-native-oom-hanging-assertions/webrev.00/webrev/src/hotspot/share/utilities/debug.cpp.udiff.html

I don't understand why you don't just leave the poison page PROT_NONE 
and call this from handle_assert_poison_fault?

+void disarm_assert_poison() {
+ g_assert_poison = &g_dummy;
+}
+

Then you don't have to check that it succeeded.   At this point, it 
doesn't matter.

Coleen

On 7/9/19 5:23 AM, Thomas Stüfe wrote:
> Dear all,
>
> may I please have reviews for the following issue:
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8227275
> cr:
> http://cr.openjdk.java.net/~stuefe/webrevs/8227275-native-oom-hanging-assertions/webrev.00/webrev/
>
> Summary: on OOM, we may fail to disarm assertion poison page; this may lead
> to endless loops during error handling if assertions happen in native OOM
> scenarios.
>
> For more details, pls see the JBS issue.
>
> Thanks, Thomas