RFR(S): 8227597: [fastdbg build] Arena::inc_bytes_allocated should get inlined
Baesken, Matthias
matthias.baesken at sap.com
Fri Jul 12 05:54:39 UTC 2019
Hi Martin, looks good to me .
Please increase the copyright year in
http://cr.openjdk.java.net/~mdoerr/8227597_DBG_Inline_inc_bytes_allocated/webrev.00/src/hotspot/share/memory/arena.cpp.frames.html
but no new webrev needed .
Best regards, Matthias
From: Doerr, Martin
Sent: Donnerstag, 11. Juli 2019 17:32
To: hotspot-runtime-dev at openjdk.java.net
Cc: Baesken, Matthias <matthias.baesken at sap.com>; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Claes Redestad <claes.redestad at oracle.com>
Subject: RFR(S): 8227597: [fastdbg build] Arena::inc_bytes_allocated should get inlined
Hi,
the simple function Arena::inc_bytes_allocated can be found as CPU consuming when profiling the fastdbg build. It is located in a cpp file.
It should better get inlined to improve the performance of the fastdbg VM which is important for complex tests.
In addition, atomic 8-Byte load and store functions are available on all platforms, so the "#if defined ..." can get removed.
Here's my proposal:
http://cr.openjdk.java.net/~mdoerr/8227597_DBG_Inline_inc_bytes_allocated/webrev.00/
Feedback is welcome.
Best regards,
Martin
More information about the hotspot-runtime-dev
mailing list