RFR(S): 8227692: Remove develop feature PrintMallocStatistics

[Doerr, Martin]

Hi Coleen and Dan,

thank you for reviewing. I've pushed it.

Best regards,
Martin


> -----Original Message-----
> From: Daniel D. Daugherty <daniel.daugherty at oracle.com>
> Sent: Donnerstag, 18. Juli 2019 16:40
> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-
> dev at openjdk.java.net
> Subject: Re: RFR(S): 8227692: Remove develop feature PrintMallocStatistics
> 
>  >
> http://cr.openjdk.java.net/~mdoerr/8227692_remove_PrintMallocStatistics/
> webrev.00/
> 
> src/hotspot/share/memory/allocation.cpp
>      No comments.
> 
> src/hotspot/share/memory/allocation.hpp
>      No comments.
> 
> src/hotspot/share/memory/allocation.inline.hpp
>      No comments.
> 
> src/hotspot/share/memory/arena.cpp
>      No comments.
> 
> src/hotspot/share/memory/arena.hpp
>      No comments.
> 
> src/hotspot/share/runtime/globals.hpp
>      No comments.
> 
> src/hotspot/share/runtime/java.cpp
>      No comments.
> 
> Thumbs up.
> 
> 
> On 7/18/19 5:09 AM, Doerr, Martin wrote:
> > Hi Dan,
> >
> > can I count this as review?
> 
> Yes, now you can... :-)
> 
> Dan
> 
> 
> >
> > Best regards,
> > Martin
> >
> >
> >> -----Original Message-----
> >> From: Daniel D. Daugherty <daniel.daugherty at oracle.com>
> >> Sent: Mittwoch, 17. Juli 2019 00:20
> >> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-
> >> dev at openjdk.java.net
> >> Cc: Baesken, Matthias <matthias.baesken at sap.com>
> >> Subject: Re: RFR(S): 8227692: Remove develop feature
> PrintMallocStatistics
> >>
> >> Thanks. Sounds good.
> >>
> >> Dan
> >>
> >>
> >> On 7/16/19 4:15 PM, Doerr, Martin wrote:
> >>> Hi Dan,
> >>>
> >>> I've added the proposal to use "-XX:NativeMemoryTracking=summary -
> >> XX:+PrintNMTStatistics" instead.
> >>> Thanks,
> >>> Martin
> >>>
> >>>
> >>>> -----Original Message-----
> >>>> From: Daniel D. Daugherty <daniel.daugherty at oracle.com>
> >>>> Sent: Dienstag, 16. Juli 2019 18:04
> >>>> To: Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-
> >>>> dev at openjdk.java.net
> >>>> Cc: Baesken, Matthias <matthias.baesken at sap.com>
> >>>> Subject: Re: RFR(S): 8227692: Remove develop feature
> >> PrintMallocStatistics
> >>>> For anyone that happens to be searching JBS for what happened to the
> >>>> '-XX:+PrintMallocStatistics' option, you might want to include some
> >>>> guidance on how they get the equivalent information from NMT...
> >>>>
> >>>> A short note in JDK-8227692 should suffice...
> >>>>
> >>>> Dan
> >>>>
> >>>>
> >>>> On 7/15/19 4:16 PM, Doerr, Martin wrote:
> >>>>> Hi,
> >>>>>
> >>>>> as announced on hotspot-dev, I'd like to remove the debug build
> >> feature
> >>>> for allocation statistics "AllocStats" (controlled by develop flag -
> >>>> XX:+PrintMallocStatistics).
> >>>>> I've closed JDK-8227597<https://bugs.openjdk.java.net/browse/JDK-
> >>>> 8227597> which was a proposal to reduce the performance impact of it,
> >> but
> >>>> several people have suggested to remove this feature which is even
> >> better
> >>>> IMHO.
> >>>>> Bug:
> >>>>> https://bugs.openjdk.java.net/browse/JDK-8227692
> >>>>>
> >>>>> Webrev:
> >>>>>
> >>
> http://cr.openjdk.java.net/~mdoerr/8227692_remove_PrintMallocStatistics/
> >>>> webrev.00/
> >>>>> I've also taken over the reworked inc_stat_counter from JDK-
> >>>> 8227597<https://bugs.openjdk.java.net/browse/JDK-8227597>
> >>>> (allocation.inline.hpp).
> >>>>> Please review.
> >>>>>
> >>>>> Best regards,
> >>>>> Martin
> >>>>>