RFR (S) 8202339: [TESTBUG] Consolidate the tests in runtime/SharedArchiveFile and runtime/appcds

[coleen.phillimore at oracle.com]

Thanks Calvin and also thanks for your help!
Coleen

On 7/26/19 2:24 PM, Calvin Cheung wrote:
>  Hi Coleen,
>
> This looks good to me.
>
> thanks,
>
> Calvin
>
> On 7/26/19 10:46 AM, coleen.phillimore at oracle.com wrote:
>>
>> Okay, trying again.  I moved SharedArchiveFile to cds and moved 
>> appcds under cds.  Now the appcds tests can be run with dynamic 
>> archiving, and all tests are run with jtreg:hotspot_cds, and they can 
>> share files from SharedArchiveFile.
>>
>> open webrev at 
>> http://cr.openjdk.java.net/~coleenp/2019/8202339.03/webrev
>>
>> Retested with tier2.
>>
>> Thanks,
>> Coleen
>>
>> On 7/24/19 10:43 PM, coleen.phillimore at oracle.com wrote:
>>>
>>> I'm going to withdraw this change.  It seems that the 
>>> SharedArchiveFile tests use different utility classes than the 
>>> appcds tests, so they fail with dynamic archiving.  It looks like 
>>> consolidating these is a lot more work!
>>>
>>> Coleen
>>>
>>> On 7/24/19 7:23 PM, Calvin Cheung wrote:
>>>> Hi Coleen,
>>>>
>>>> Thanks for doing this tests consolidation.
>>>>
>>>> In TEST.groups, for the hotspot_appcds_dynamic test group (starting 
>>>> from line 313), I think we need to exclude the tests which used to 
>>>> reside under the SharedArchiveFile dir as well.
>>>>
>>>> You can use mach5 to test it by supplying the following args:
>>>>
>>>> --test hotspot_appcds_dynamic --jvm-args 
>>>> "Dtest.dynamic.cds.archive=true"
>>>>
>>>> or if you'd like to run it locally using jtreg, add the following 
>>>> args:
>>>>
>>>> -vmoptions:-Dtest.dynamic.cds.archive=true 
>>>> <jdk>/open/test/hotspot/jtreg:hotspot_appcds_dynamic
>>>>
>>>> (where <jdk> is the full path to the top dir of your repo)
>>>>
>>>> thanks,
>>>>
>>>> Calvin
>>>>
>>>> On 7/24/19 10:38 AM, coleen.phillimore at oracle.com wrote:
>>>>> Summary: moved appcds and SharedArchive files to 
>>>>> test/hotspot/runtime/cds
>>>>>
>>>>> This is 99% tedious.  I moved the files with hg move and fixed the 
>>>>> directory references in the tests to 'cds'. Tested with mach5 
>>>>> hs-tier1,2,3.
>>>>>
>>>>> open webrev at 
>>>>> http://cr.openjdk.java.net/~coleenp/2019/8202339.01/webrev
>>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8202339
>>>>>
>>>>> Thanks,
>>>>> Coleen
>>>
>>