RFR(s): 8222015: Small VM.metaspace improvements

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri May 3 20:42:07 UTC 2019


This looks good to me as well.  Sorry for the delay in reviewing.
Coleen

On 4/26/19 1:17 PM, Thomas Stüfe wrote:
> Hi all,
>
> Latest version, with changes requested by Jiangli:
>
> full:
> http://cr.openjdk.java.net/~stuefe/webrevs/8222015--small-vm.metaspace-improvements/webrev.01/webrev/
> delta:
> http://cr.openjdk.java.net/~stuefe/webrevs/8222015--small-vm.metaspace-improvements/webrev_delta.01/webrev/
>
> May I have a second reviewer, please?
>
> Thank you.
>
> Best Regards, Thomas
>
> On Fri, Apr 5, 2019 at 12:06 PM Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
>
>> Hi all,
>>
>> may I have please a review for this collection of small improvements to
>> the VM.metaspace diagnostic command?
>>
>> - it clearly marks now classes whose metadata reside in cds
>> - it shows the number of classes loaded, incl. those from cds, in the
>> overviews too.
>>
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8222015
>> cr:
>> http://cr.openjdk.java.net/~stuefe/webrevs/8222015--small-vm.metaspace-improvements/webrev.00/webrev/
>>
>> Example output:
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8222015--small-vm.metaspace-improvements/example-by-spacetype.txt
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8222015--small-vm.metaspace-improvements/example-showloaders.txt
>>
>> http://cr.openjdk.java.net/~stuefe/webrevs/8222015--small-vm.metaspace-improvements/example-showloaders-showclasses.txt (scroll
>> down -> cds classes in <bootstrap> are now marked with 's')
>>
>> Thank you,
>>
>> Thomas
>>



More information about the hotspot-runtime-dev mailing list