RFR (S) 8223956: Make SymbolTable and StringTable AllStatic
gerard ziemski
gerard.ziemski at oracle.com
Wed May 15 18:48:54 UTC 2019
hi Coleen,
Looks great overall, really cleaned up the files nicely.
Two small things:
#1 you removed "private" from the stringTable.hpp at the top of the
class (line 51). I know the visibility is private by default, by we
still set it explicitly "private" regardless in other files (ex.
symbolTable.hpp), and we did it here before, so we should follow the
pattern (no need for new webrev for that)
#2 why did you drop "const" from SymbolTable::get_load_factor() ?
cheers
On 5/15/19 9:40 AM, coleen.phillimore at oracle.com wrote:
> Summary: Removed superfluous and confusing _the_table pointer.
>
> Ran hs tier1-3.
>
> open webrev at http://cr.openjdk.java.net/~coleenp/2019/8223956.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8223956
>
> Thanks,
> Coleen
>
More information about the hotspot-runtime-dev
mailing list