RFR(XS): 8224165: [TESTBUG] Docker tests produce excessive output

David Holmes david.holmes at oracle.com
Thu May 23 03:23:49 UTC 2019


Looks fine to me Misha!

Thanks,
David

On 23/05/2019 1:12 pm, mikhailo.seledtsov at oracle.com wrote:
> Here is the updated webrev: 
> http://cr.openjdk.java.net/~mseledtsov/8224165.01/
> 
> The stdout of the docker process is saved into a 
> 'docker-stdout-<pid>.log'. I can see the log file when running jtreg 
> locally.
> 
> Testing on the test cluster is in progress; I have injected some 
> failures into tests, to make sure the logs are saved.
> 
> 
> Misha
> 
> On 5/21/19 7:46 AM, mikhailo.seledtsov at oracle.com wrote:
>> Leonid, David,
>>
>>   Thank you for the initial review and feedback. I will implement 
>> Leonid's suggestion about directing the child output to a file. This 
>> way the log output from the child process will be saved.
>>
>>
>> Thank you,
>>
>> Misha
>>
>>
>> On 5/20/19 11:19 PM, David Holmes wrote:
>>> Hi Misha,
>>>
>>> On 21/05/2019 2:14 pm, mikhailo.seledtsov at oracle.com wrote:
>>>> Please review this change that limits how much of child process 
>>>> output is copied into
>>>> the main test output. Docker tests child processes produce too much 
>>>> output at times, which results in JT harness
>>>> trimming the output, and can lead to loss of important diagnostic 
>>>> information.
>>>
>>> But if you limit the child output in the log you might still be 
>>> losing important diagnostic information from the child.
>>>
>>> David
>>> -----
>>>
>>>>      JBS: https://bugs.openjdk.java.net/browse/JDK-8224165
>>>>      Webrev: http://cr.openjdk.java.net/~mseledtsov/8224165.00/
>>>>      Testing:
>>>>         Ran HotSpot and JDK docker tests
>>>>             test/hotspot/jtreg/containers/docker/
>>>>             test/jdk/jdk/internal/platform/docker/
>>>>
>>>>         No new failures
>>>>
>>>> Thank you,
>>>> Misha
>>>>
>>


More information about the hotspot-runtime-dev mailing list