RFR(xs) 8231606: _method_ordering is not set during CDS dynamic dump time

Jiangli Zhou jianglizhou at google.com
Tue Oct 1 19:53:46 UTC 2019


On Tue, Oct 1, 2019 at 12:15 PM <coleen.phillimore at oracle.com> wrote:
>
>
> It might be a good idea to go through and add some
>
> public static bool is_dumping_archive() { return DumpSharedSpaces ||
> DynamicDumpSharedSpaces); }
>
> And replace all of these sets of conditionals with it, since it appears
> that this case was missed.

I was going to suggest something similar with a macro. A function
probably is better.

Best,
Jiangli
>
> Coleen
>
> On 10/1/19 1:14 PM, Calvin Cheung wrote:
> > bug: https://bugs.openjdk.java.net/browse/JDK-8231606
> >
> > webrev: http://cr.openjdk.java.net/~ccheung/8231606/webrev.00/
> >
> > A small fix for setting up the _method_ordering field during CDS
> > dynamic dumping.
> >
> > Testing: tier1 - 3.
> >
> > thanks,
> >
> > Calvin
> >
>


More information about the hotspot-runtime-dev mailing list