RFR(XL): 8220310: Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)

Kim Barrett kim.barrett at oracle.com
Wed Oct 16 14:00:35 UTC 2019

> On Oct 15, 2019, at 10:33 AM, sangheon.kim at oracle.com wrote:
> Hi all,
> Here's revised webrev which addresses:
> 1) G1RegionToSpaceMapper checks mtJavaHeap and then conditionally calls G1NUMA::request_memory_on_node() (Kim)
> 2) The signature of G1NUMA::request_memory_on_node(void* address, ,) is changed to have actual address instead of page index. (Stefan)
> 3) Some local variable name changes at G1RegionToSpaceMapper. i -> region_idx, idx -> page_idx (for local style, used idx instead of index)
> webrev:
> http://cr.openjdk.java.net/~sangheki/8220310/webrev.5/
> http://cr.openjdk.java.net/~sangheki/8220310/webrev.5.inc/
> Testing: hs-tier 1 ~ 5, with/without UseNUMA

Looks good.

In g1PageBasedVirtualSpace.cpp, could the newly added definition of page_size()
be moved to be near the existing definition of page_start()?  I don’t need a new
webrev if you move it.

More information about the hotspot-runtime-dev mailing list