RFR: 8231471: Obsolete -XX:CompilationPolicyChoice

[Claes Redestad]

Hi David,

this was actually caught by an assertion (expiry version has to be
larger than obsoletion version), and I had already run the tests on a
version that is fixed according to your note, but forgot to update in
place. Done now.

/Claes

On 2019-09-27 01:11, David Holmes wrote:
> Hi Claes,
> 
> This is the obsoletion step of removing the flag (where the flag is 
> ignored and a warning issued), the actual removal of the flag happens in 
> a future version so in arguments.cpp this:
> 
> +   { "CompilationPolicyChoice",       JDK_Version::jdk(13), 
> JDK_Version::jdk(14), JDK_Version::jdk(14) },
> 
> should be:
> 
> +   { "CompilationPolicyChoice",       JDK_Version::jdk(13), 
> JDK_Version::jdk(14), JDK_Version::jdk(15) },
> 
> and at the beginning of the JDK 15 cycle we will delete all such entries 
> from the table.
> 
> Thanks,
> David
> 
> On 26/09/2019 11:27 pm, Claes Redestad wrote:
>> Hi,
>>
>> CompilationPolicyChoice was deprecated in 13 with the goal of obsoleting
>> it in 14.
>>
>> Webrev: http://cr.openjdk.java.net/~redestad/8231471/webrev.00/
>> Bug:    https://bugs.openjdk.java.net/browse/JDK-8231471
>>
>> Since removing CompilationPolicyChoice makes it impossible to select and
>> run the StackWalkCompPolicy I've removed that code, along with 2 develop
>> flags only used by it.
>>
>> StackWalkCompPolicy was the C2 default before 6, but abandoned in favor
>> of the simpler C1 policy since it resulted in better startup and similar
>> or better performance[1]. The choice to go back has remained as an
>> undocumented options, and we've seen no reports of it being used.
>>
>> Testing: tier1-3
>>
>> Thanks!
>>
>> /Claes