RFR: 8242283: Can't start JVM when java home path includes non-ASCII character

[Harold Seigel]

The hotspot  changes look good!

Thanks, Harold

On 4/10/2020 9:18 PM, Yasumasa Suenaga wrote:
> Thanks Sato-san!
>
> I added noreg-hard to JBS.
>
> Can I get reviewer(s) from HotSpot folks?
> This webrev changes HotSpot code (os_windows.cpp).
>
>
> Yasumasa
>
>
> On 2020/04/11 2:17, naoto.sato at oracle.com wrote:
>> Suenaga-san,
>>
>> Looks good to me. Please add noreg-hard if you are not planning to 
>> provide test cases. Thank you for fixing this issue.
>>
>> Naoto
>>
>> On 4/10/20 7:29 AM, Yasumasa Suenaga wrote:
>>> Hi all,
>>>
>>> Please review this change:
>>>
>>>    JBS: https://bugs.openjdk.java.net/browse/JDK-8242283
>>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8242283/webrev.00/
>>>
>>> After JDK-8240197 and JDK-8240725, java cannot start when java home 
>>> path includes non-ASCII character e.g. Japanese Kanji.
>>> We've discussed about this issue on JBS, and we decide to replace 
>>> CP_THREAD_ACP to CP_ACP in MultiByteToWideChar() because CP_ACP 
>>> works nicely rather than CP_THREAD_ACP.
>>>
>>> But this change would not resolve in all cases. For example, 
>>> Japanese encoded pathname cannot be recognized under the English 
>>> system locale. It is (implicitly) described in the spec for 
>>> JNI_CreateJavaVM().
>>>
>>> https://docs.oracle.com/en/java/javase/14/docs/specs/jni/invocation.html#jni_createjavavm: 
>>>
>>> ```
>>>      char *optionString; /* the option as a string in the default 
>>> platform encoding */
>>> ```
>>>
>>>
>>> Thanks,
>>>
>>> Yasumasa