RFR (trivial) 8244173: Uncomment subtest in runtime/InvocationTests/invocationC1Tests.java

[Igor Ignatyev]

LGTM

-- Igor

> On Apr 30, 2020, at 3:21 PM, David Holmes <david.holmes at oracle.com> wrote:
> 
> On 1/05/2020 3:28 am, Harold Seigel wrote:
>> That test should be uncommented also.  David, can you include it in your change?
> 
> Done.
> 
> http://cr.openjdk.java.net/~dholmes/8244173/webrev.v2/
> 
> Thanks Igor - I have no idea how I missed that. I was sure I had grepped for other occurrences. <sigh>
> 
> Thanks,
> David
> 
>> Thanks, Harold
>> On 4/30/2020 1:19 PM, Igor Ignatyev wrote:
>>> Harold, David,
>>> 
>>> what about test/hotspot/jtreg/runtime/InvocationTests/invokevirtualTests.java which also has some subtest commented out b/c of  8226588 ?
>>>>      76 // Uncomment the below test once JDK-8226588 is fixed
>>>>       77 //      runTest(String.valueOf(major_version), "-Xcomp");
>>> -- Igor
>>> 
>>>> On Apr 30, 2020, at 5:13 AM, Harold Seigel <harold.seigel at oracle.com> wrote:
>>>> 
>>>> Hi David,
>>>> 
>>>> The fix looks good and trivial.
>>>> 
>>>> Thanks for fixing this.
>>>> 
>>>> Harold
>>>> 
>>>> On 4/30/2020 3:36 AM, David Holmes wrote:
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8244173
>>>>> webrev: http://cr.openjdk.java.net/~dholmes/8244173/webrev/
>>>>> 
>>>>> runtime/InvocationTests/invocationC1Tests.java has this:
>>>>> 
>>>>> 
>>>>>        // Uncomment this test once JDK-8226588 is fixed
>>>>>          // runTest("invokevirtual.Generator", String.valueOf(major_version));
>>>>> 
>>>>> JDK-8226588 morphed into JDK-8227467 and has now been fixed, so this subtest can be uncommented.
>>>>> 
>>>>> Harold: I spotted this by chance during another code review and didn't find a follow-up issue filed to fix it, so I filed one and fixed it. :)
>>>>> 
>>>>> Testing: itself
>>>>>           tiers 1-3 (in progress)
>>>>> 
>>>>> Thanks,
>>>>> David