RFR(XS) 8238198 Avoid using @ tags in TestOptionsWithRanges_generate.sh

mikhailo.seledtsov at oracle.com mikhailo.seledtsov at oracle.com
Sat Feb 1 00:36:02 UTC 2020


+1

On 1/31/20 10:56 AM, Igor Ignatev wrote:
> LGTM.
>
> — Igor
>
>> On Jan 29, 2020, at 3:58 PM, Ioi Lam <IOI.LAM at oracle.com> wrote:
>>
>> Oh, you're right! I can't believe I messed up so many times ...
>>
>> Here's the proper fix (I think) on line #22. Jtreg doesn't parse the /* @test ... */, so I left them the same as before:
>>
>> http://cr.openjdk.java.net/~iklam/jdk15/8238198-avoid-at-char-in-TestOptionsWithRanges_generate.sh.v02/
>>
>> Thanks
>> - Ioi
>>
>>> On 1/29/20 3:48 PM, Igor Ignatyev wrote:
>>> so it's not @test at L#22, interesting... LGTM.
>>>
>>> -- Igor
>>>
>>>
>>>>> On Jan 29, 2020, at 3:39 PM, Mikhailo Seledtsov <mikhailo.seledtsov at oracle.com> wrote:
>>>> Looks good
>>>>
>>>> On 1/29/20, 2:28 PM, Ioi Lam wrote:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8238198
>>>>> http://cr.openjdk.java.net/~iklam/jdk15/8238198-avoid-at-char-in-TestOptionsWithRanges_generate.sh.v01/
>>>>>
>>>>> Hi, here's a better fix than what I did in JDK-8237046 [1]
>>>>>
>>>>> It is probably a bug in jtreg that it thinks the script is a test due to
>>>>> the existence of /* @test ... */. But to be safe, we should replace
>>>>> @test with ${at}test.
>>>>>
>>>>> Thanks
>>>>> - Ioi
>>>>>
>>>>> [1] https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-January/037899.html


More information about the hotspot-runtime-dev mailing list