RFR (S): 8236844: Deprecate PrintVMQWaitTime to prepare for its removal

David Holmes david.holmes at oracle.com
Thu Feb 6 22:01:53 UTC 2020


Hi Harold,

Thanks for the review.

On 6/02/2020 11:02 pm, Harold Seigel wrote:
> Hi David,
> 
> The change looks good.  Could you also remove PrintVMQWaitTime from 
> test/jdk/com/sun/management/HotSpotDiagnosticMXBean/CheckOrigin.java ?

That will happen when the flag is obsoleted in JDK 16.

But thanks for the pointer, I hadn't expected to find any test 
references to this flag. :)

David

> Thanks, Harold
> 
> On 2/6/2020 2:18 AM, David Holmes wrote:
>> bug: https://bugs.openjdk.java.net/browse/JDK-8236844
>> CSR request: https://bugs.openjdk.java.net/browse/JDK-8238584
>> webrev: http://cr.openjdk.java.net/~dholmes/8236844/webrev/
>>
>> I originally considered converting PrintVMQWaitTime to Unified 
>> Logging, but after some discussions and considering that proper 
>> logging of the VM operations involves a lot more than this one 
>> existing print statement, it was decided just to deprecate and then 
>> remove this flag (and the one print statement). There is other work in 
>> the safepoint/VM-ops area that will address appropriate logging as 
>> needed.
>>
>> I also need reviewers for the CSR request please (first one needs to 
>> Edit the CSR request so that the 'Reviewers' field then appears).
>>
>> Thanks,
>> David


More information about the hotspot-runtime-dev mailing list