RFR (S): 8238999: Remove MemRegion custom new/delete operator overloads
Thomas Schatzl
thomas.schatzl at oracle.com
Tue Feb 18 10:01:35 UTC 2020
Hi Jiangli, Kim, Ioi,
thanks for your review.
On 15.02.20 00:14, Jiangli Zhou wrote:
> On Fri, Feb 14, 2020 at 3:05 PM Kim Barrett <kim.barrett at oracle.com> wrote:
>>
>>> On Feb 14, 2020, at 10:05 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>> can I have reviews for this small change to the MemRegion class to remove unnecessary new/delete overloads from MemRegion.
>>>[...]
>> ------------------------------------------------------------------------------
>> src/hotspot/share/memory/memRegion.hpp
>> 96 // Creates and initializes an array of MemRegions of the given length.
>> 97 static MemRegion* create(uint length, MEMFLAGS flags);
>>
>> A function named "create" suggests to me creating a single object, not
>> an array. Perhaps "make_array" or "create_array" or "new_array"?
>
> +1. I had the same thoughts when looking at the webrev.1.
>
> Best regards,
> Jiangli
I pushed with "create_array"; for reference, the webrevs:
http://cr.openjdk.java.net/~tschatzl/8238999/webrev.1_to_2/ (diff(
http://cr.openjdk.java.net/~tschatzl/8238999/webrev.2/ (full)
Thanks,
Thomas
More information about the hotspot-runtime-dev
mailing list