RFR(S) 8239449: [TESTBUG] test/hotspot/jtreg/runtime/TLS/TestTLS.java: skip test if glibc too old for AdjustStackSizeForTLS

Jiangli Zhou jianglizhou at google.com
Wed Feb 19 18:23:57 UTC 2020


Hi Richard,

David's suggestion of using dlsym seems to be more reliable. Regarding
the stability of __pthread_get_minstack in future glibc versions,
Florian has added comment to __pthread_get_minstack about external
users to ensure it's not removed until TCB is separately allocated.
Please see: http://51.15.138.76/patch/18989/ and
https://gcc.gnu.org/bugzilla//show_bug.cgi?id=91628#c2.

Best regards,
Jiangli




On Wed, Feb 19, 2020 at 2:44 AM Reingruber, Richard
<richard.reingruber at sap.com> wrote:
>
> Hi,
>
> please review this small test fix
>
> Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8239449/webrev.0/
> Bug:    https://bugs.openjdk.java.net/browse/JDK-8239449
>
> On linux systems with older glibc versions (e.g. 2.11) the option -XX:+AdjustStackSizeForTLS has no effect, because the private function __pthread_get_minstack is not provided, and the test fails. With the fix the test is skipped instead.
>
> Thanks, Richard.


More information about the hotspot-runtime-dev mailing list