RFR(XS) 8239854: Cannot build gtest without PCH after 8239235. Missing include in test/hotspot/gtest/runtime/test_signatureStream.cpp

[Reingruber, Richard]

Thanks all. I just pushed the fix.

Richard.

-----Original Message-----
From: Claes Redestad <claes.redestad at oracle.com> 
Sent: Montag, 24. Februar 2020 12:13
To: Reingruber, Richard <richard.reingruber at sap.com>; Aleksey Shipilev <shade at redhat.com>; Doerr, Martin <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(XS) 8239854: Cannot build gtest without PCH after 8239235. Missing include in test/hotspot/gtest/runtime/test_signatureStream.cpp

Looks good,

and thanks for the periodic reminder that PCH should be an opt-in.

/Claes

On 2020-02-24 12:03, Reingruber, Richard wrote:
> Thanks Aleksey and Martin,
> 
> I changed the synopsis and sorted the includes, but kept the newline at the end of the file.
> 
> Are you ok with it?
> 
> Thanks, Richard.
> 
> diff --git a/test/hotspot/gtest/runtime/test_signatureStream.cpp b/test/hotspot/gtest/runtime/test_signatureStream.cpp
> --- a/test/hotspot/gtest/runtime/test_signatureStream.cpp
> +++ b/test/hotspot/gtest/runtime/test_signatureStream.cpp
> @@ -22,8 +22,9 @@
>    */
>   
>   #include "precompiled.hpp"
> +#include "classfile/symbolTable.hpp"
> +#include "memory/resourceArea.hpp"
>   #include "runtime/interfaceSupport.inline.hpp"
> -#include "classfile/symbolTable.hpp"
>   #include "runtime/signature.hpp"
>   #include "threadHelper.inline.hpp"
>   #include "unittest.hpp"
> @@ -85,4 +86,4 @@
>   
>     ASSERT_EQ(foo->refcount(), r1) << "refcount should have decremented";
>   
> -}
> \ No newline at end of file
> +}
> 
> -----Original Message-----
> From: Aleksey Shipilev <shade at redhat.com>
> Sent: Montag, 24. Februar 2020 11:41
> To: Reingruber, Richard <richard.reingruber at sap.com>; Claes Redestad <claes.redestad at oracle.com>; hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(XS) 8239854: Cannot build gtest without PCH after 8239235. Missing include in test/hotspot/gtest/runtime/test_signatureStream.cpp
> 
> On 2/24/20 11:35 AM, Reingruber, Richard wrote:
>> diff --git a/test/hotspot/gtest/runtime/test_signatureStream.cpp b/test/hotspot/gtest/runtime/test_signatureStream.cpp
>> --- a/test/hotspot/gtest/runtime/test_signatureStream.cpp
>> +++ b/test/hotspot/gtest/runtime/test_signatureStream.cpp
>> @@ -22,6 +22,7 @@
>>    */
>>   
>>   #include "precompiled.hpp"
>> +#include "memory/resourceArea.hpp"
>>   #include "runtime/interfaceSupport.inline.hpp"
>>   #include "classfile/symbolTable.hpp"
>>   #include "runtime/signature.hpp"
>> @@ -85,4 +86,4 @@
>>   
>>     ASSERT_EQ(foo->refcount(), r1) << "refcount should have decremented";
>>   
>> -}
>> \ No newline at end of file
>> +}
> 
> Looks good and trivial.
> 
> Maybe drop the newline hunk? I have no strong preference here.
> 
> Maybe synopsis could be a bit shorter?
>   "Non-PCH gtest build fails after JDK-8239235 due to a missing include"
>