Build failure on illumos after 8238988

[Daniel D. Daugherty]

On 2/28/20 9:53 AM, Aleksey Shipilev wrote:
> On 2/28/20 3:47 PM, Daniel D. Daugherty wrote:
>> I filed the following for you:
>>
>>       JDK-8240231 Build failure on illumos after 8238988
>>       https://bugs.openjdk.java.net/browse/JDK-8240231
> Daniel, would you also be taking care of it?
>
> I think we can push this simple fix blindly (i.e. without having Solaris machines to test on),
> relying on Peter's own testing.

Daniel? Am I in trouble with you Aleksey? :-)

Ya gotta stop reading my mind... it's a dangerous place to be :-)


$ hg diff -r qparent
diff -r 27e301f90b3a src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp
--- a/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp    Fri Feb 
28 09:53:18 2020 +0100
+++ b/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp    Fri Feb 
28 10:05:04 2020 -0500
@@ -89,7 +89,7 @@
      ret_fp = NULL;
    } else {
      // sp is reasonable is fp reasonable?
-    if (!jt->is_in_stack_range_incl((address)ret_fp, ret_sp)) {
+    if (!jt->is_in_stack_range_incl((address)ret_fp, (address)ret_sp)) {
        ret_fp = NULL;
      }
    }

$ hg log -v -r tip
changeset:   58200:e3ad904d6062
user:        dcubed
date:        Fri Feb 28 10:03:49 2020 -0500
files:       src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp
description:
8240231: Build failure on illumos after 8238988
Summary: add missing cast
Reviewed-by: dcubed, shade
Contributed-by: peter.tribble at gmail.com

Good to go?

Dan