Build failure on illumos after 8238988

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Feb 28 17:00:56 UTC 2020


On 2/28/20 11:47 AM, Peter Tribble wrote:
> On Fri, Feb 28, 2020 at 3:06 PM Daniel D. Daugherty 
> <daniel.daugherty at oracle.com <mailto:daniel.daugherty at oracle.com>> wrote:
>
>     On 2/28/20 9:53 AM, Aleksey Shipilev wrote:
>     > On 2/28/20 3:47 PM, Daniel D. Daugherty wrote:
>     >> I filed the following for you:
>     >>
>     >>       JDK-8240231 Build failure on illumos after 8238988
>     >> https://bugs.openjdk.java.net/browse/JDK-8240231
>     > Daniel, would you also be taking care of it?
>     >
>     > I think we can push this simple fix blindly (i.e. without having
>     Solaris machines to test on),
>     > relying on Peter's own testing.
>
>     Daniel? Am I in trouble with you Aleksey? :-)
>
>     Ya gotta stop reading my mind... it's a dangerous place to be :-)
>
>
>     $ hg diff -r qparent
>     diff -r 27e301f90b3a
>     src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp
>     --- a/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp Fri Feb
>     28 09:53:18 2020 +0100
>     +++ b/src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp Fri Feb
>     28 10:05:04 2020 -0500
>     @@ -89,7 +89,7 @@
>           ret_fp = NULL;
>         } else {
>           // sp is reasonable is fp reasonable?
>     -    if (!jt->is_in_stack_range_incl((address)ret_fp, ret_sp)) {
>     +    if (!jt->is_in_stack_range_incl((address)ret_fp,
>     (address)ret_sp)) {
>             ret_fp = NULL;
>           }
>         }
>
>     $ hg log -v -r tip
>     changeset:   58200:e3ad904d6062
>     user:        dcubed
>     date:        Fri Feb 28 10:03:49 2020 -0500
>     files: src/hotspot/os_cpu/solaris_x86/thread_solaris_x86.cpp
>     description:
>     8240231: Build failure on illumos after 8238988
>     Summary: add missing cast
>     Reviewed-by: dcubed, shade
>     Contributed-by: peter.tribble at gmail.com
>     <mailto:peter.tribble at gmail.com>
>
>     Good to go?
>
>
>  I see that's been committed. Many thanks for the quick response!

Yup. I decided to go ahead and push on the assumption that Aleksey
would be okay with it since he asked if I was taking care of it. :-)

Dan


>
> -- 
> -Peter Tribble
> http://www.petertribble.co.uk/ 
> <https://urldefense.com/v3/__http://www.petertribble.co.uk/__;!!GqivPVa7Brio!P27QmT5EJwNr4DxdK1zRSqpYQBM4t8G3f_pwdRDqNffqBhtiksODLvbUMyUb5nYvAb8c$> 
> - http://ptribble.blogspot.com/ 
> <https://urldefense.com/v3/__http://ptribble.blogspot.com/__;!!GqivPVa7Brio!P27QmT5EJwNr4DxdK1zRSqpYQBM4t8G3f_pwdRDqNffqBhtiksODLvbUMyUb5tJzvgkH$>



More information about the hotspot-runtime-dev mailing list