RFR(XS): https://bugs.openjdk.java.net/browse/JDK-8240258
Calvin Cheung
calvin.cheung at oracle.com
Sat Feb 29 03:17:10 UTC 2020
Hi Yumin,
Looks good.
The block of code between lines 1157 and 1381 already enclosed by #if
INCLUDE_CDS, so I'd suggest moving the quick_resolve function to before
line 1381. This would avoid having another #if INCLUDE_CDS in this file.
It's up to you if you want to make this change.
thanks,
Calvin
On 2/28/20 7:03 PM, Yumin Qi wrote:
> Hi,
>
> Can I have a quick review for this XS change as supplemental fix to
> https://bugs.openjdk.java.net/browse/JDK-8236604.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8240258
>
> Webrev: http://cr.openjdk.java.net/~minqi/8240258/webrev/
>
> Summary: need CDS guard the new added function
> SystemDictionary::quick_resolve.
>
> The other issue related to CDS guard is handled with
> https://bugs.openjdk.java.net/browse/JDK-8240254.
>
> Thanks
>
> Yumin
>
More information about the hotspot-runtime-dev
mailing list