RFR(M): 8236555: [s390] Fix VerifyOops
Doerr, Martin
martin.doerr at sap.com
Fri Jan 10 15:53:14 UTC 2020
Hi Lutz and Götz,
thank you for the reviews. Pushed to jdk14 as requested by Götz.
> Note: I'm not a Reviewer.
But your review is perfectly fine as 2nd review. I couldn't imagine finding a better person for the job of reviewing s390 assembly changes!
Best regards,
Martin
> -----Original Message-----
> From: Schmidt, Lutz <lutz.schmidt at sap.com>
> Sent: Freitag, 10. Januar 2020 15:52
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; Doerr, Martin
> <martin.doerr at sap.com>; hotspot-runtime-dev at openjdk.java.net
> Subject: RE: RFR(M): 8236555: [s390] Fix VerifyOops
>
> Martin,
>
> your change looks good. Nice "trick" to save the CC.
>
> Note: I'm not a Reviewer.
>
> Thanks,
> Lutz
>
>
> On 27.12.19, 16:09, "hotspot-runtime-dev on behalf of Lindenmaier, Goetz"
> <hotspot-runtime-dev-bounces at openjdk.java.net on behalf of
> goetz.lindenmaier at sap.com> wrote:
>
> Hi Martin,
>
> The change looks good. Nice you also added line number information.
> Can you still push this to jdk14? The test is failing there, too.
> I think you can rate this as P3 bug.
>
> Best regards,
> Goetz.
>
> From: Doerr, Martin <martin.doerr at sap.com>
> Sent: Friday, December 27, 2019 1:01 PM
> To: hotspot-runtime-dev at openjdk.java.net; Lindenmaier, Goetz
> <goetz.lindenmaier at sap.com>
> Subject: RFR(M): 8236555: [s390] Fix VerifyOops
>
> Hi,
>
> parts of the implementation for VerifyOops for s390 are missing.
> I'd like to make the develop feature -XX:+VerifyOops usable.
>
> Webrev:
>
> http://cr.openjdk.java.net/~mdoerr/8236555_s390_VerifyOops/webrev.00/
>
> Please review.
>
> Best regards,
> Martin
>
>
More information about the hotspot-runtime-dev
mailing list